Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "cancelled" and newsflash to ical feed #799

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ionous
Copy link
Contributor

@ionous ionous commented Aug 17, 2024

google calendar doesn't indicated canceled events well, so this prepends it to the ride title. this also adds the newsflash, since that's often part of canceling; ( and therefore fixes #723 )

for example, the feed for https://www.shift2bikes.org/calendar/event-19594 now looks like:

UID:[email protected]
SUMMARY:CANCELLED: The Stark Street Swooper: Ventura to Multnomah Falls
via Dabney, Corbett, and Vista House
DESCRIPTION:Excessive Heat Ride to Far to risk any lives, Moved over to
next week let\n
Join us at 9:30AM for this exhilarating ride starting at

the bold parts are new.

( note: the newsflash here "correctly" ends with the word "let" -- it matches the text on the website. maybe user error, or more likely clipped on input/storage to the db? doesn't affect this issue tho. )

google calendar doesn't indicated canceled events well, so this prepends it to the ride title.
this also adds the newsflash, since that's often part of canceling; ( and therefore fixes shift-org#723 )
@carrythebanner
Copy link
Collaborator

@ionous You're right, there is a bug in handling the newsflash (filed that as #800). This PR shouldn't have any effect on that so we can still merge this.

@carrythebanner carrythebanner merged commit 9ed2e2a into shift-org:main Aug 19, 2024
4 checks passed
@ionous ionous deleted the feed-cancel branch August 20, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

newsflash should be part of the ical description
2 participants