Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include access restrictions for Advanced tool site #62

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

mirrorofstripes
Copy link
Contributor

The azurerm_windows_function_app resource provider defaults to scm_use_main_ip_restriction = false, therefore I propose including a setting to restrict the Advanced tool site to the same IP addresses as specified in the main site restrictions to preemptively curtail any possible misuse as well as explicitly restricting it to TLS 1.2 only.

Copy link
Owner

@shibayan shibayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@shibayan shibayan merged commit c8d5af7 into shibayan:master Mar 18, 2024
2 checks passed
@mirrorofstripes mirrorofstripes deleted the patch-1 branch March 19, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants