Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX (before submit): save html content to textarea before shortcode change #58

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

Neumes
Copy link

@Neumes Neumes commented Jul 11, 2017

Save the updated content from the html editor to the underlying text area before the shortcode's html is replaced with the actual shortcode. This way the shortcode tag will be in the database instead of the html tag.

The fix in 165ce3b was 99% of the way there, just the wrong way around

This should fix #45 as well as #49 for 3.0. I'll pull request the fix for master as well.

@sheadawson sheadawson merged commit 8fa191f into sheadawson:3.0 Jul 11, 2017
@sheadawson
Copy link
Owner

Nice one! Does this also fix the dreaded #52 by chance? Sorry I haven't had time to look at this module for a while

@Neumes
Copy link
Author

Neumes commented Jul 11, 2017

I'm unsure on whether or not this will fix #52 unfortunately however I'm digging around on this one as we speak, so I'll let you know if I can reasonably conclude whether or not this fixes that as well

@sheadawson
Copy link
Owner

sheadawson commented Jul 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants