Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE placeholders not being reverted to shortcode format before save to DB #49

Closed
jonom opened this issue Nov 23, 2016 · 1 comment
Closed

Comments

@jonom
Copy link
Contributor

jonom commented Nov 23, 2016

As @tomstgeorge noted in #45, this commit has caused a breaking regression

just made this edit to shortcodable.js and it does fix the 'edit HTML source not saving' issue but breaks the saving of the inserted shortcode dataobject.
Now when I publish the page the embeded shortocde dataobject shows on the frontend as an image i.e. they are no longer being converted into shortcodes on save.
When I look in the database they are stored as the image and not being saved as e.g [myObject id="2"]

@sheadawson
Copy link
Owner

Yes this is not cool, I don't have time to look at it at the moment but can merge right away if anyone submits a fix

jonom added a commit to jonom/silverstripe-shortcodable that referenced this issue Dec 1, 2016
This reverts commit 165ce3b, due to introducing breaking change sheadawson#49
sheadawson added a commit that referenced this issue Dec 1, 2016
MrJamesEllis pushed a commit to MrJamesEllis/silverstripe-shortcodable that referenced this issue Feb 23, 2017
…ontent using setContent, call _super for saving of HTMLEditorField content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants