Added support for custom output filenames and temp files in subfolders #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement this package in our e2e tests I made some changes:
This is how we implemented it in our e2e env. It starts a recording for each
it
in a test. When the test succeeds the video is not rendered and the temp dir is cleared. When a test fails, the video is compiled and the temp dir is also cleared. At the end of all tests therecording/
folder only contains the .webm video files of failed tests.We then upload these videos together with the test results to slack using a github action.
@shaynet10