Improved device parsing to use None when finding empty strings

shauntarves · May 12, 2021 · 8b0eb67 · 8b0eb67
1 parent bc11bce
commit 8b0eb67
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/wyze_sdk/models/__init__.py b/wyze_sdk/models/__init__.py
@@ -67,7 +67,8 @@ def _extract_attribute(self, name: str, others: dict) -> Any:
         Extracts a single value by name from a variety of locations in an object.
         """
         if name in others:
-            return others.pop(name)
+            value = others.pop(name)
+            return value if value is not None and value != "" else None
 
         if 'property_list' in others:
             for property in others['property_list']:

diff --git a/wyze_sdk/models/devices/base.py b/wyze_sdk/models/devices/base.py
@@ -123,10 +123,16 @@ def __init__(
         else:
             self._ts = None
         if value is not None and not isinstance(value, self._definition.type):
-            try:
-                value = bool(distutils.util.strtobool(str(value))) if self._definition.type == bool else self._definition._type(value)
-            except ValueError:
-                self.logger.warning(f"could not cast value `{value}` into expected type {self._definition.type}")
+            if value == "":
+                value = None
+            else:
+                try:
+                    value = bool(distutils.util.strtobool(str(value))) if self._definition.type == bool else self._definition._type(value)
+                except ValueError:
+                    self.logger.warning(f"def {self._definition.pid}")
+                    self.logger.warning(f"could not cast value `{value}` into expected type {self._definition.type}")
+        if value == "":
+            value = None
         self._value = value
 
     @property