Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use the trip start and end location directly
Instead of looking up the place and getting it instead. This has two advantages over the current implementation: 1. We don't have to make 2 separate database calls for each trip Note that we compute an nxn distance matrix, so this is likely to be a substantial savings 2. We can pass in a in-memory trip list. That makes it easier to write unit tests, and to use alternate load methods (e.g. for working with federated data e-mission/e-mission-eval-private-data@952c476 @corinne-hcr reported that the place location and the trip start/loc locations are not identical. We don't have unit tests to verify this (alas!) but the top level results are not changed significantly. So the ROI seems high enough; we are going ahead with this change. e-mission#826 (comment)
- Loading branch information