-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSharp_邹东耘_无25 #12
Open
strangerTHU
wants to merge
1
commit into
shangfengh:main
Choose a base branch
from
strangerTHU:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CSharp_邹东耘_无25 #12
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
using System; | ||
using System.Diagnostics.Metrics; | ||
using System.Security.Cryptography.X509Certificates; | ||
|
||
namespace Homework1 | ||
{ | ||
|
@@ -43,7 +45,7 @@ public interface IProgress | |
/// 如果之前进度条已经加载完成,则将进度清零开始下一次加载,返回true,但如果requiredProgress<0,应当报错 | ||
/// 如果之前进度条尚未加载完成,返回false | ||
/// </summary> | ||
public bool Start(int requiredProgress); | ||
public bool Start(int requiredProgress); | ||
|
||
public void Add(int addProgress); //增加addProgress的进度 | ||
public void Sub(int subProgress); //减少subProgress的进度 | ||
|
@@ -60,6 +62,72 @@ public class Progress : IProgress | |
// 一个进度条 | ||
// 只允许修改Progress类中的代码 | ||
// 要求实现IProgress中的要求 | ||
static public int counter = 0; | ||
public int Num { get; set; } // Progress的序号,表明是第几个实例化的Progress | ||
public int RequiredProgress { get; set; } // Progress加载完成所需进度 | ||
public int FinishedProgress { get; set; } // FinishedProgress指其中已完成的进度, FinishedProgress应当在[0,RequiredProgress]中public int Num { get; } | ||
public Progress() | ||
{ | ||
counter++; | ||
Num = counter; | ||
} | ||
public void Add(int addProgress) | ||
{ | ||
if (FinishedProgress + addProgress <= RequiredProgress) | ||
{ | ||
if(FinishedProgress + addProgress>=0) | ||
FinishedProgress += addProgress; | ||
else FinishedProgress = 0; | ||
} | ||
else | ||
{ | ||
FinishedProgress = RequiredProgress; | ||
} | ||
} | ||
public void Sub(int subProgress) | ||
{ | ||
if(FinishedProgress - subProgress >=0) | ||
{ | ||
if(FinishedProgress-subProgress <=RequiredProgress) | ||
FinishedProgress -= subProgress; | ||
else FinishedProgress = RequiredProgress; | ||
} | ||
else | ||
{ | ||
FinishedProgress = 0; | ||
} | ||
} | ||
|
||
public void Double() | ||
{ | ||
if(2*FinishedProgress<=RequiredProgress) | ||
{ | ||
FinishedProgress = 2 * FinishedProgress; | ||
} | ||
else { FinishedProgress = RequiredProgress; } | ||
} | ||
|
||
/// <summary> | ||
/// FinishedProgress指其中已完成的进度,RequiredProgress指当前Progress完成所需进度 | ||
/// </summary> | ||
public (int FinishedProgress, int RequiredProgress) GetProgress() | ||
{ | ||
return (FinishedProgress, RequiredProgress); | ||
} | ||
public bool Start(int requiredProgress) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 没有按要求实现Start |
||
{ | ||
|
||
if(requiredProgress>0) | ||
{ | ||
RequiredProgress = requiredProgress; | ||
return true; | ||
} | ||
else | ||
{ | ||
throw (new Exception("RequiredProgress must be positive.")); | ||
} | ||
|
||
} | ||
} | ||
|
||
/* | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
本意是希望能在set访问器里限制 FinishedProgress的范围的,特别是多人研发时能确保安全。
但是事实上即便设置了属性,类内依旧可以访问字段,属性更像对类外操作的要求。
所以不开放set访问器(要保证赋值总是合法的,不能让外界无条件修改),只在方法内进行范围限制也合理
这里应当考虑private set