#959

Improve UX Further
shanalikhan · Jul 22, 2019 · c91cba3 · c91cba3
2 parents 76f64a6 + df7554d
commit c91cba3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/service/webview.service.ts b/src/service/webview.service.ts
@@ -436,12 +436,14 @@ export class WebviewService {
       } else {
         gistSelectionPanel.dispose();
       }
+    });
+    webview.webview = gistSelectionPanel;
+    gistSelectionPanel.onDidDispose(() => {
+      webview.webview = null;
       if (cmd) {
         vscode.commands.executeCommand(cmd);
       }
     });
-    webview.webview = gistSelectionPanel;
-    gistSelectionPanel.onDidDispose(() => (webview.webview = null));
     return gistSelectionPanel;
   }
 

diff --git a/ui/gist-selection/gist-selection.js b/ui/gist-selection/gist-selection.js
@@ -67,7 +67,13 @@ appendHTML(skipContainer, skip);
 const selectionTemplate = `
 <button type="button" onclick="saveGistId('@id')" class="list-group-item list-group-item-action">@description (@id) – Updated @timestamp ago</button>`;
 
-gists
+if (!gists.length) {
+  appendHTML(
+    selectionContainer,
+    "<p>No Gists found on your account. Skip this window and upload the settings to create a new Gist.</p>"
+  );
+} else {
+  gists
   .sort((a, b) => new Date(b.updated_at) - new Date(a.updated_at))
   .forEach(gist => {
     const html = selectionTemplate
@@ -79,3 +85,5 @@ gists
       );
     appendHTML(selectionContainer, html);
   });
+}
+