Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT: Modify Assertion checking + Assumptions prototype #61

Merged
merged 38 commits into from
May 2, 2021

Conversation

shamindras
Copy link
Owner

@shamindras shamindras commented Apr 1, 2021

This is per #60

Assertion Checking fixes

Per discussion we should implement the following:

  • Update assertion checking for get_summary() and summary()
  • Update assertion checking for get_confint() and confint()
  • Check whether we need to update assertion checking for print()

Update tibble based assumptions

  • @shamindras : Setup a prototype of get_assumptions() to use tibbles
  • @shamindras : Do the same for the variance titles
  • @shamindras : Do the same for the variance emojis
  • @shamindras : Ensure that this flows through to comp_var() and it contains only tibbles
  • @shamindras : Ensure that the flow through to other parts of the code is easier using the revised tibbles

Quick questions

  • Do we need this line? If not, we should just remove it in a commit

@shamindras shamindras added the feature a feature request or enhancement label Apr 1, 2021
shamindras and others added 26 commits April 1, 2021 08:59
@shamindras shamindras merged commit bddb14d into main May 2, 2021
@shamindras shamindras deleted the iss-60-assertion-getassmps branch May 2, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants