Enable containerized demo #64
Open
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguanus
commented
Jun 8, 2024
| @@ -23,7 +23,7 @@ development: | |||
| # Reference: https://webpack.js.org/configuration/dev-server/ | |||
| dev_server: | |||
| https: false | |||
| host: localhost | |||
There was a problem hiding this comment.
0.0.0.0 is required, as the container is not in the same space as the host.
For truly remote, such as CodeSpaces, one might also need to change the allowed list below
iguanus
commented
Jun 8, 2024
| rails: bundle exec rails s -p 3000 | ||
| rails: bundle exec rails s -b 0.0.0.0 -p 3000 |
There was a problem hiding this comment.
Enable accepting requests from outside the container, like from the browser.
iguanus
commented
Jun 8, 2024
Dockerfile
Outdated
Comment on lines
36
to
37
| # Run the app when the container launches | ||
| CMD ["foreman", "start", "-f", "Procfile.dev"] |
There was a problem hiding this comment.
This could be configured differently, but it is likely a good idea to try to run both bare metal and containers through the same commands to avoid the need to update in multiple places when change comes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
localhost->0.0.0.0, as browser is usually not within the container)This change is