- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace Webpacker with Shakapacker #1622
Merged
justin808
merged 81 commits into
shakacode:master
from
adriangohjw:fix-uninitialized-constant-Webpacker
Jun 28, 2024
+571
−415
Merged
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
156df7f
fix: replace Webpacker with Shakapacker
adriangohjw 6df4e8d
add changelog entry
Judahmeek 5051a55
update gemfile to use shakapacker 8.0.0
adriangohjw 6212747
Replace Webpacker with Shakapacker
adriangohjw 39b32e2
Update WebpackerUtils to ShakapackerUtils
adriangohjw 8c0d019
(spec) package.json - update shakapacker to v8 + add "packageManager"
adriangohjw 7723165
fix specs - Update Webpacker to Shakapacker
adriangohjw 797ea16
Fix rubocop linting error
adriangohjw f1c6fd7
remove post-install action for shakapacker < v7
adriangohjw 8559b2c
fix: updated test description and context tag
adriangohjw d832db4
update min. shakapacker version to 7.2.1
adriangohjw 4609d03
use adapter method for Shakapacker
Judahmeek 812c94c
Ci fixes & linting
Judahmeek 328aacb
per review
Judahmeek 52c0ea8
Ci fix for changed-files
Judahmeek 3711e9c
revert changes to install generator
Judahmeek 7810da0
WIP
Judahmeek 0d82c02
still wip
Judahmeek 2ec90b8
getting there?
Judahmeek ae8fba8
more wip
Judahmeek bfaf244
remove appraisal and dynamically modify gemfiles
Judahmeek d33ad0a
wip again
Judahmeek 446c090
more fixes
Judahmeek 8a0003e
fixes more
Judahmeek 15db710
still fixing
Judahmeek 789958e
hopefully getting somewhere
Judahmeek 96bcb5f
more fixes
Judahmeek e82d924
resolve install generator errors
Judahmeek 6cc3d4f
additional fixes
Judahmeek 25edd25
debugging integration failure
Judahmeek de5bfaf
add log statements
Judahmeek 07f2e72
use info from log statements to resolve issues
Judahmeek 19ddd8c
fix invalid job configurations
Judahmeek 5cc7a81
add log statements to debug new issues
Judahmeek 62c69db
further debugging
Judahmeek 4fac40f
fix debug statement
Judahmeek 4c9568a
fix other debug statement
Judahmeek 32945f7
maybe fixes
Judahmeek 0f3bdcd
fix maybes
Judahmeek 861d544
resolve pack gen errors
Judahmeek 60b0ec0
whatever
Judahmeek e2090b4
maybe maybe
Judahmeek 1017815
all integration specs should be passing
Judahmeek f3be6af
linting
Judahmeek 24c8d5a
further linting
Judahmeek 00827e4
add example debug statement
Judahmeek 0f6ddcb
add missing method
Judahmeek 15cbe82
focus on generator job
Judahmeek b6d0201
debug yarn install
Judahmeek 196dd26
debug/fix for packageManager key
Judahmeek 6ba18dc
separate tasks by packer type
Judahmeek d6300a3
skip corepack check
Judahmeek 8b673f2
debug more
Judahmeek 2e94227
potential fix
Judahmeek 321adf0
try again
Judahmeek 6444653
closer
Judahmeek 8162ee7
fail-fast false
Judahmeek a694c99
closer
Judahmeek 2a5d78d
no point in matrix if shakapacker v6 doesn't support node 16
Judahmeek aaa2140
one more fix
Judahmeek afe89b3
Revert "focus on generator job"
Judahmeek 428fd66
remove debug statements
Judahmeek ed3806f
Revert "no point in matrix if shakapacker v6 doesn't support node 16"
Judahmeek 21fa4ea
revert 'one more fix'
Judahmeek 43d15d0
remove all jobs except generators again
Judahmeek 9b063e7
use Node v20 for all gen tests
Judahmeek 6a640c5
add debug statement
Judahmeek 2726d61
move example_type initialization logic to run_rspec file
Judahmeek 4ca8cf1
linting & debug statement removal
Judahmeek a03e171
Revert "remove all jobs except generators again"
Judahmeek 3a8df96
restore shakapacker to Gemfile & package.json
Judahmeek d77929e
restore dumy apps rake task
Judahmeek 4c3cb9b
use shakapacker v8 by default
Judahmeek 1915582
create a script to convert shakapacker support from v8 to v6
Judahmeek d08a465
use conversion script for CI
Judahmeek 2061f3a
linting
Judahmeek 82a2aa7
fixes?
Judahmeek b5e7939
final fixes?
Judahmeek 4cce360
update Contributing doc
Judahmeek c96a47e
using_xpacker? > using_xpacker_const?
Judahmeek b8c5d28
linting
Judahmeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
debug/fix for packageManager key
commit 196dd26ab4956cd4607ba8c51c1eb95ec7b701dc
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,6 +76,9 @@ def add_base_gems_to_gemfile | |
end | ||
|
||
def add_yarn_dependencies | ||
`cat package.json` | ||
gsub_file("package.json", /^"packageManager": ".*"(,?)$/, '^"packageManager": "[email protected]"\1$') | ||
`cat package.json` | ||
major_minor_patch_only = /\A\d+\.\d+\.\d+\z/ | ||
if ReactOnRails::VERSION.match?(major_minor_patch_only) | ||
run "yarn add react-on-rails@#{ReactOnRails::VERSION} --exact" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Review and confirm Yarn dependencies handling in
add_yarn_dependencies
.The
gsub_file
operation intended to update thepackageManager
field to"[email protected]"
does not seem to be working as expected. Thepackage.json
file does not contain thepackageManager
field after running the operation. Please manually verify the syntax and execution of thegsub_file
command to ensure it correctly updates thepackageManager
field.Analysis chain
Review and confirm Yarn dependencies handling in
add_yarn_dependencies
.This method updates Yarn dependencies handling. Ensure that the version handling and updates to dependencies are correct and align with the project's requirements.
Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 142
Script:
Length of output: 60
Script:
Length of output: 2851