Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS vulnerabilities in dev dependencies #1604

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Apr 2, 2024

Summary

Updated JS dependencies for security fixes

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

This change is Reviewable

@ahangarha ahangarha force-pushed the ahangarha/fix-js-vulnerabilities-apr-3 branch from 2422605 to d1486bc Compare April 3, 2024 00:13
@ahangarha
Copy link
Contributor Author

This PR only affects dev dependencies!
We may ignore it for now.

@ahangarha ahangarha closed this Apr 3, 2024
@justin808
Copy link
Member

@ahangarha it's OK to fix dev dependencies. Why close this?

@justin808 justin808 reopened this Apr 3, 2024
@ahangarha
Copy link
Contributor Author

Why close this?

Just to prevent distraction for now, as it is not needed for the upcoming release.
For that, I commented: "We may ignore it for now".

@ahangarha ahangarha force-pushed the ahangarha/fix-js-vulnerabilities-apr-3 branch from d1486bc to e06d24a Compare April 5, 2024 23:03
@ahangarha ahangarha changed the title Fix JS vulnerabilities Fix JS vulnerabilities in dev dependencies Apr 5, 2024
@justin808
Copy link
Member

changelog?

@justin808 justin808 merged commit 493a2f5 into master Apr 5, 2024
19 checks passed
@justin808 justin808 deleted the ahangarha/fix-js-vulnerabilities-apr-3 branch April 5, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants