Skip to content

Commit

Permalink
revert peer dependencies bump, remove configLoader (#1600)
Browse files Browse the repository at this point in the history
* Revert bumping peer-dependencies version
* Remove deprecated configLoader
  • Loading branch information
ahangarha authored Jan 31, 2024
1 parent f5c34d4 commit 660579c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 106 deletions.
7 changes: 1 addition & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,9 @@ Please follow the recommendations outlined at [keepachangelog.com](http://keepac
### [Unreleased]
Changes since the last non-beta release.

#### Changed
- Bump minimum version of peer dependencies as following [PR 1596](https://github.com/shakacode/react_on_rails/pull/1596) by [ahangarha](https://github.com/ahangarha).
- `js-yaml` to `4.1.0`
- `react` and `react-dom` to `17.0.0`

#### Removed
- Dropped Ruby 2.7 support [PR 1595](https://github.com/shakacode/react_on_rails/pull/1595) by [ahangarha](https://github.com/ahangarha).
- Dropped support for Node 14 and 17 [PR 1596](https://github.com/shakacode/react_on_rails/pull/1596) by [ahangarha](https://github.com/ahangarha).
- Removed deprecated `webpackConfigLoader.js` [PR 1600](https://github.com/shakacode/react_on_rails/pull/1600) by [ahangarha](https://github.com/ahangarha).

### [13.4.1]
#### Fixed
Expand Down
25 changes: 1 addition & 24 deletions docs/javascript/troubleshooting-when-using-webpacker.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,30 +43,7 @@ At the same time dev/prod environments works fine (with extra webpack calling st

### webpack.config.js

```js
...
const ManifestPlugin = require('webpack-manifest-plugin');
...
const { output } = webpackConfigLoader(configPath);
...
output: {
filename: '[name]-[hash].js',

// Leading and trailing slashes ARE necessary.
publicPath: output.publicPath,
path: output.path,
},
...
plugins: [
...
new ManifestPlugin({
publicPath: output.publicPath,
writeToFileEmit: true
}),
...
]
...
```
See [Shakapcker Webpack Configuration](https://github.com/shakacode/shakapacker/blob/master/README.md#webpack-configuration).

### config/webpacker.yml

Expand Down
9 changes: 4 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,12 @@
"@babel/runtime-corejs3": "^7.12.5"
},
"peerDependencies": {
"js-yaml": ">= 4.1.0",
"react": ">= 17",
"react-dom": ">= 17"
"js-yaml": ">= 3.0.0",
"react": ">= 16",
"react-dom": ">= 16"
},
"files": [
"node_package/lib",
"webpackConfigLoader.js"
"node_package/lib"
],
"scripts": {
"test": "jest node_package/tests",
Expand Down
71 changes: 0 additions & 71 deletions webpackConfigLoader.js

This file was deleted.

0 comments on commit 660579c

Please sign in to comment.