whatever

shakacode · Jun 26, 2024 · 60b0ec0 · 60b0ec0
1 parent 861d544
commit 60b0ec0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -84,6 +84,7 @@ jobs:
   dummy-app-integration-tests:
     needs: build-dummy-app-webpack-test-bundles
     strategy:
+      fail-fast: false
       matrix:
         versions: ['oldest', 'newest']
     runs-on: ubuntu-22.04

diff --git a/spec/dummy/spec/rake/assets_precompile_rake_spec.rb b/spec/dummy/spec/rake/assets_precompile_rake_spec.rb
@@ -3,6 +3,7 @@
 require "rake"
 
 require "rails_helper"
+require "react_on_rails"
 
 describe "rake assets:precompile task" do
   it "doesn't show deprecation message for using webpacker:clean task" do
@@ -12,7 +13,7 @@
     Rails.application.load_tasks
 
     ReactOnRails.configure do |config|
-      config.build_production_command = "RAILS_ENV=production NODE_ENV=production bin/shakapacker"
+      config.build_production_command = "RAILS_ENV=production NODE_ENV=production bin/#{ReactOnRails::PackerUtils.packer_type}"
     end
 
     expect do

diff --git a/spec/dummy/spec/rake/assets_rake_spec.rb b/spec/dummy/spec/rake/assets_rake_spec.rb
@@ -35,7 +35,7 @@ def self.call
 
     Rake::Task["react_on_rails:assets:webpack"].execute
 
-    expect(BuildProductionCommand).to have_received(:call)
+    expect(BuildProductionCommand).to have_received(:call).twice
     expect(File).to exist(filepath)
   end