debugging integration failure

shakacode · Jun 25, 2024 · 25edd25 · 25edd25
1 parent 6cc3d4f
commit 25edd25
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -172,6 +172,7 @@ jobs:
         git config user.email "[email protected]"
         git config user.name "Your Name"
         git commit -am "stop generators from complaining about uncommitted code"
+    - run: bundle info shakapacker
     - name: Main CI
       run: bundle exec rake run_rspec:all_dummy
     - name: Store test results

diff --git a/rakelib/shakapacker_examples.rake b/rakelib/shakapacker_examples.rake
@@ -34,7 +34,7 @@ namespace :shakapacker_examples do # rubocop:disable Metrics/BlockLength
       example_type.rails_options += "--skip-javascript"
       sh_in_dir(examples_dir, "rails new #{example_type.name} #{example_type.rails_options}")
       sh_in_dir(example_type.dir, "touch .gitignore")
-      append_to_gemfile(example_type.gemfile)
+      append_to_gemfile(example_type.gemfile, example_type.dir)
       bundle_install_in(example_type.dir)
       sh_in_dir(example_type.dir, "rake shakapacker:install")
       sh_in_dir(example_type.dir, example_type.generator_shell_commands)
@@ -58,7 +58,7 @@ private
 
 # Appends each string in an array as a new line of text in the given Gemfile.
 # Automatically adds line returns.
-def append_to_gemfile(gemfile)
+def append_to_gemfile(gemfile, dir)
   relative_gem_root = Pathname(gem_root).relative_path_from(Pathname(dir))
   lines = [
     "gem 'react_on_rails', path: '#{relative_gem_root}'",

diff --git a/rakelib/webpacker_examples.rake b/rakelib/webpacker_examples.rake
@@ -34,7 +34,7 @@ namespace :webpacker_examples do # rubocop:disable Metrics/BlockLength
       example_type.rails_options += "--skip-javascript"
       sh_in_dir(examples_dir, "rails new #{example_type.name} #{example_type.rails_options}")
       sh_in_dir(example_type.dir, "touch .gitignore")
-      append_to_gemfile(example_type.gemfile)
+      append_to_gemfile(example_type.gemfile, example_type.dir)
       bundle_install_in(example_type.dir)
       sh_in_dir(example_type.dir, "rake webpacker:install")
       sh_in_dir(example_type.dir, example_type.generator_shell_commands)
@@ -58,7 +58,7 @@ private
 
 # Appends each string in an array as a new line of text in the given Gemfile.
 # Automatically adds line returns.
-def append_to_gemfile(gemfile)
+def append_to_gemfile(gemfile, dir)
   relative_gem_root = Pathname(gem_root).relative_path_from(Pathname(dir))
   lines = [
     "gem 'react_on_rails', path: '#{relative_gem_root}'",