Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix CBCS support in some platforms #63

Merged
merged 5 commits into from
May 7, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented May 6, 2024

Fixes #62

@avelad avelad requested review from joeyparrish and theodab May 6, 2024 11:02
@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels May 6, 2024
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish May 7, 2024 04:37
@avelad
Copy link
Member Author

avelad commented May 7, 2024

@joeyparrish can you review it again? Thanks!

index.js Outdated Show resolved Hide resolved
@avelad
Copy link
Member Author

avelad commented May 7, 2024

It seems that your change introduce an error, can you review it?

@joeyparrish
Copy link
Member

I'm on it

@joeyparrish joeyparrish merged commit 3978d61 into shaka-project:main May 7, 2024
3 checks passed
@avelad avelad deleted the cbcs-support branch May 7, 2024 16:27
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Oct 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polyfill returns misleading CBCS
2 participants