Add default default octave depending on KK model #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrb0
commented
Feb 10, 2018
src/devices/ni/KompleteKontrol.cpp
Outdated
| KompleteKontrolBase::KompleteKontrolBase(const NUM_KEYS numKeys) | ||
| : m_numKeys(static_cast<unsigned>(numKeys)) | ||
| , m_ledsKeysSize(m_numKeys * 3U) | ||
| , m_ledsKeys(new uint8_t[m_ledsKeysSize]) |
There was a problem hiding this comment.
c style array creation, since you're using pointers for data writing I didn't change this to a vector
There was a problem hiding this comment.
maybe a shared_ptr with the array is an option here
src/devices/ni/KompleteKontrol.cpp
Outdated
| @@ -311,6 +332,7 @@ KompleteKontrolBase::KompleteKontrolBase() | |||
|
|
|||
| KompleteKontrolBase::~KompleteKontrolBase() | |||
| { | |||
| delete[] m_ledsKeys; | |||
There was a problem hiding this comment.
delete based destruction. A bit ugly, maybe there's a better way to do this
src/devices/ni/KompleteKontrol.cpp
Outdated
| @@ -22,6 +22,23 @@ const uint8_t kKK_ledsDataSize = 25; | |||
|
|
|||
| const uint8_t kKK_epOut = 0x02; | |||
| const uint8_t kKK_epInput = 0x84; | |||
|
|
|||
| size_t getInitialOctave(const sl::cabl::KompleteKontrolBase::NUM_KEYS numKeys) | |||
There was a problem hiding this comment.
maybe there's a better name for this
…the default octave
nrb0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the concept of templated KKS1 child class. The number of keys is an argument of the base class
This is done in order to initialize the
m_firstOctaveto the default keyboard value depending (which depends on the size)This change is