-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make new palm flesh the default palm for Hands E and G (lite) #844
Open
rnzenha-s
wants to merge
8
commits into
noetic-devel
Choose a base branch
from
F#_SWC-65_make_new_palm_flesh_default_for_hands_e_and_g
base: noetic-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make new palm flesh the default palm for Hands E and G (lite) #844
rnzenha-s
wants to merge
8
commits into
noetic-devel
from
F#_SWC-65_make_new_palm_flesh_default_for_hands_e_and_g
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and 'robot_description_semantic' parameters exists at node launch
…t_for_hands_e_and_g
niko-holmes
reviewed
Dec 10, 2024
niko-holmes
approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## noetic-devel #844 +/- ##
=============================================
Coverage 40.19% 40.19%
=============================================
Files 13 13
Lines 1555 1555
Branches 637 637
=============================================
Hits 625 625
Misses 647 647
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make new hand versions (with new palm flesh) the default versions for Hands E and G (lite), respectively, versions E4 and G4.
Also, renaming node
error_reporter
node tounderactuation_error_reporter
for clarity purposes and ensuring parametersrobot_description
androbot_description_semantics
are discoverable before starting the node.Update: This PR also now introduces fixes to some of our ROS tests (specifically, those invoking the method move_group.compute_cartesian_path() ), so that they now conform with the latest API changes to moveit_commander:
moveit/moveit#3618
Specifically, the argument
jump_threshold
has now been deprecated, and, therefore, had to be removedChecklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
Documentation