Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new palm flesh the default palm for Hands E and G (lite) #844

Open
wants to merge 8 commits into
base: noetic-devel
Choose a base branch
from

Conversation

rnzenha-s
Copy link
Contributor

@rnzenha-s rnzenha-s commented Dec 10, 2024

Proposed changes

Make new hand versions (with new palm flesh) the default versions for Hands E and G (lite), respectively, versions E4 and G4.
Also, renaming node error_reporter node to underactuation_error_reporter for clarity purposes and ensuring parameters robot_description and robot_description_semantics are discoverable before starting the node.

Update: This PR also now introduces fixes to some of our ROS tests (specifically, those invoking the method move_group.compute_cartesian_path() ), so that they now conform with the latest API changes to moveit_commander:
moveit/moveit#3618
Specifically, the argument jump_threshold has now been deprecated, and, therefore, had to be removed

Checklist

Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.

Tests

  • No tests required to be added. (For small changes that will be tested by CI/CD infrastructure).
  • Added/Modified automated and PhantomHand CI tests (if a new class is added (Python or C++), the interface of that class must be unit tested).
  • Manually tested in simulation (if simulation specific or no hardware required to test the functionality).
  • Manually tested on hardware (if hardware specific or related).

Documentation

  • No documentation required to be added.
  • Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc).
  • Updated documentation (For changes to pre-existing features mentioned in the documentation).

@rnzenha-s rnzenha-s requested review from a team as code owners December 10, 2024 16:56
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.19%. Comparing base (bce86fb) to head (684a456).

Additional details and impacted files
@@              Coverage Diff              @@
##           noetic-devel     #844   +/-   ##
=============================================
  Coverage         40.19%   40.19%           
=============================================
  Files                13       13           
  Lines              1555     1555           
  Branches            637      637           
=============================================
  Hits                625      625           
  Misses              647      647           
  Partials            283      283           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants