Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load ur10 kinematics_config without an arm #533

Closed

Conversation

Jntzko
Copy link
Contributor

@Jntzko Jntzko commented Jul 29, 2020

Proposed changes

The ur10 kinematics config should not be loaded if the shadow hand is used without an arm.
Without this patch you need a custom ur_description package in your workspace even if you don't use it.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Read and follow the contributing guidelines.
  • Checked that all tests pass with my changes
  • Added tests (automatic or manual) that prove the fix is effective or that the feature works
  • Added necessary documentation (if appropriate)
  • Added the corresponding license to each file and add the current year of any one that you modified.
  • Tested on real hardware (if appropriate)

@v4hn

The ur10 kinematics config should not be loaded if the shadow hand is used without an arm.
Without this patch we need a custom ur_description package in your workspace even if you don't use it.
@ethanfowler
Copy link
Contributor

ethanfowler commented Aug 14, 2020

Hi, due to some recent changes this would be a difficult merge, please could you confirm that this PR:
#541
satisfies your requirements @Jntzko ?

@Jntzko
Copy link
Contributor Author

Jntzko commented Aug 19, 2020

Yes, this PR satisfies my requirements, thank you!

@Jntzko Jntzko closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants