-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added config and launch files UR10 and hand lite #187
Conversation
@@ -0,0 +1,17 @@ | |||
robot: | |||
name: ur10srh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be worth having a different robot name for the ur10 with hand lite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in different parts of the launch files so I don't think it is not a good idea to change the names.
@@ -0,0 +1,48 @@ | |||
<launch> | |||
<!-- This launch file is for the right ur10 arm and a shadow hand --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add 'lite' here
<!-- Serial number of the hand to be used--> | ||
<arg name="hand_serial" default="1082"/> | ||
<!-- the path to the mapping files --> | ||
<arg name="mapping_path" default="$(find sr_edc_launch)/mappings/default_mappings/rh_E_v3.yaml"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the mapping be rh_lite_v1.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixed it
<arg name="arm_id" value="ra"/> | ||
<arg name="side" value="$(arg side)"/> | ||
<arg name="robot_model" value="ur10"/> | ||
<arg name="robot_name" value="ur10srh"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you do change the robot name (comment above) it needs to be changed here too
@@ -0,0 +1,29 @@ | |||
<robot xmlns:xacro="http://ros.org/wiki/xacro" name="ur10srh"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if changing robot name, needs to be changed here too (see next comment)
Why do we need a new launch file? Normally we just pass the desired robot_description to the existing sr_right_ur10arm_hand.launch isn't it? |
Current coverage is 22.60% (diff: 100%)
|
Gazebo still has problems with this (#136) but it will be ok with real robot