New hand G (lite) version with new plam flesh - Hand version G4 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2024 15:55
…black (thumb was already black). Add resources necessary to make the new palm compatible with hand E lite
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## noetic-devel #172 +/- ##
================================================
+ Coverage 33.33% 36.36% +3.03%
================================================
Files 1 1
Lines 21 22 +1
Branches 15 15
================================================
+ Hits 7 8 +1
Partials 14 14 ☔ View full report in Codecov by Sentry. |
niko-holmes
reviewed
Dec 10, 2024
Comment on lines
41
to
71
| <technique sid="blender"> | ||
| <phong> | ||
| <emission> | ||
| <color>0.00000 0.00000 0.00000 1</color> | ||
| </emission> | ||
| <ambient> | ||
| <color>0.05997 0.05997 0.05997 1</color> | ||
| </ambient> | ||
| <diffuse> | ||
| <color>0.16355 0.16355 0.16355 1</color> | ||
| </diffuse> | ||
| <specular> | ||
| <color>0.36585 0.36585 0.36585 1</color> | ||
| </specular> | ||
| <shininess> | ||
| <float>12.5</float> | ||
| </shininess> | ||
| <reflective> | ||
| <color>1.00000 1.00000 1.00000 1</color> | ||
| </reflective> | ||
| <reflectivity> | ||
| <float>0.0</float> | ||
| </reflectivity> | ||
| <transparent> | ||
| <color>1 1 1 1</color> | ||
| </transparent> | ||
| <transparency> | ||
| <float>0.0</float> | ||
| </transparency> | ||
| </phong> | ||
| </technique> |
There was a problem hiding this comment.
Huh, good question 🤨
There was a problem hiding this comment.
Should be fixed now (mismatch of tabs and spaces)
niko-holmes
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
It adds a new version of hand-hand G (Dand lite)—G4—which contains the new plam flesh.
Makes this new hand G version the default one (unless otherwise specified in
sr_hand_configfor each individual hand, or using thehand_versionrobot launch file argument)It also fixes a "bug" where STF tips (FF, MF, RF, LF) were being visualised in gazebo in a white colour. They will now be displayed in black.
Checklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
Documentation