Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make aurora use conda ansible #622

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

make aurora use conda ansible #622

wants to merge 48 commits into from
+102 −50

Conversation

carebare47
Copy link
Contributor

Proposed changes

make aurora use conda ansible

Checklist

Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.

Tests

  • No tests required to be added. (For small changes that will be tested by CI/CD infrastructure).
  • Added/Modified automated and PhantomHand CI tests (if a new class is added (Python or C++), the interface of that class must be unit tested).
  • Manually tested in simulation (if simulation specific or no hardware required to test the functionality).
  • Manually tested on hardware (if hardware specific or related).

Documentation

  • No documentation required to be added.
  • Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc).
  • Updated documentation (For changes to pre-existing features mentioned in the documentation).

@carebare47 carebare47 requested review from a team as code owners September 19, 2024 10:36
toliver
toliver requested changes Sep 20, 2024
View reviewed changes
bin/run-ansible.sh Outdated
ansible_galaxy_executable=ansible-galaxy
# Use conda packages/modules first
export PYTHONPATH="${shadow_conda_ws_dir}/lib/python3.8/site-packages"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to hardcode the python version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0e7c2b6
0194890

toliver
toliver requested changes Sep 20, 2024
View reviewed changes
bin/run-ansible.sh Outdated Show resolved Hide resolved
carebare47 and others added 18 commits September 20, 2024 13:23
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
0a82dc0
is ansible_control node local to server ec2 test?
7f4034b
set execution bit for Desktop folder (make ec2 checks work)
0357969
add dbus-launch to gio set
43f8e49
debugging gio info
cd50fab
gio info on .desktop file instead (debug)
6133ab3
forgive me
1e2b5c6
@rnzenha-s
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
4663ecf
try ubuntu desktop gui ami (for icon deployment)
738e6e1
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
4858c9f
move to ami with unattended upgrade disabled
e924912
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
2641cfc
attempted idempotency fix
2a40854
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
5fc125e
changed_when: false on icon template (why is this not idempotent?)
cbed28a
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
5ed2f23
indent on demo-icons, remove skip task from dolphin-icons
46cd8d7
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
8e7081e
@rnzenha-s rnzenha-s mentioned this pull request Sep 23, 2024
Closed
7 tasks
Build Tools and others added 24 commits September 23, 2024 14:54
oops
04ae0d7
indent
1af7163
more errors
9dee7bb
oops
8cc29c8
make gio idempotent
1663e7f
cleaner
0fa0e9a
escape spaces
bafb73a
testing
27b8c60
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
b56a94a
try escaping spaces again
ca0061e
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
fdbf3f8
still can't escape
bb3ad83
grep returns 1 on no match
7e8b086
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
59cbc3e
idempotency
2a01a21
idempotence
eed73a0
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
0ac65aa
idempotence
e444988
Merge branch 'master' of github.com:shadow-robot/aurora
3d345bd
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
c55386a
(hopefully) final idempotence, disable icon python tests
7a6fa56
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
e6d1413
trigger checks
f69570e
@carebare47
Merge branch 'master' into F#SWC-50_make_aurora_use_conda_ansible
d12bed7
@niko-holmes
Copy link
Contributor

Do not merge until #626 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnzenha-s rnzenha-s rnzenha-s approved these changes

@toliver toliver toliver approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carebare47 @niko-holmes @toliver @rnzenha-s