feat: add linux-arm64 target and make build workflow more syntatically consistent #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr has the objective to simplify the build and publish workflows simpler, making the addition of additional targets easier.
The way that this was archived was by modifying the extensions path loading to be simpler, using only
process.platform
andprocess.arch
to determine the binary path instead of more complicated logic found previously.This simplification of the path loading and adding of lead to the modification of the build script to fix the only change to the path with windows and to add the
linux-arm64
.This lead to the renaming of the environment variables expected of the script to ones that more closely align with the release files from the https://github.com/shader-slang/slang repository.
And lastly, I rewrote the publish workflow with a more modular approach in mind, where the build files are cached for that workflow and then used for publishing on both GitHub Releases and the Visual Studio Marketplace.
With this, the process to add new architectures or platforms is now way simpler, only needing to modify the build script and build workflow to include the extra target.
The workflow in this PR will probably not run considering the missing macos binary releases from the main repo, however, all changes were tested locally on my Linux x86_64 machine and worked correctly. I was not able to test with a arm machine or a windows machine to see if there were any regressions.