Adding write locks to refresh API as well

Signed-off-by: Sagar Upadhyaya <[email protected]>
sgup432 · Jan 3, 2024 · 49aab1f · 49aab1f
1 parent 1832df9
commit 49aab1f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/server/src/main/java/org/opensearch/common/cache/tier/TieredSpilloverCache.java b/server/src/main/java/org/opensearch/common/cache/tier/TieredSpilloverCache.java
@@ -204,10 +204,14 @@ public Iterable<K> cacheKeys(CacheStoreType type) {
     public void refresh(CacheStoreType type) {
         switch (type) {
             case ON_HEAP:
-                onHeapCache.refresh();
+                try (ReleasableLock ignore = writeLock.acquire()) {
+                    onHeapCache.refresh();
+                }
                 break;
             case DISK:
-                onDiskCache.ifPresent(ICache::refresh);
+                try (ReleasableLock ignore = writeLock.acquire()) {
+                    onDiskCache.ifPresent(ICache::refresh);
+                }
                 break;
             default:
                 throw new IllegalArgumentException("Unsupported Cache store type: " + type);