-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks and instructions for a workable windows build #13
base: master
Are you sure you want to change the base?
Conversation
@bathal1 , this is to make the python bindings compilable in windows. Would you mind checking that they are not broken in linux/Mac systems by adding this? |
The #if defined(_MSC_VER)
# define BOTSCH_EXPORT(__declspec(dllexport))
#else
# define BOTSCH_EXPORT
#endif |
I've added the macro and tested that the windows build goes through okay. In doing so, I've potentially shown my hand as not-really-a-c++-developer. Feel free to make changes directly or advise me on how to modify the source. P.S. If you're familiar with windows build systems, any idea how to have cmake produce Edit: What I mean is that visual studio seems to want |
Thanks. You can switch to a static library by changing the |
Hi, I've encountered the same issues as @AtheMathmo some months ago and I've been successfully using a static build of the library on Linux and Windows for quite some time. Now after some quick googling, adding this seems to be the actual fix for building the shared library with CMake >= 3.4:
EDIT: Also, instead of having a separate install section for each OS, it's probably better to just use the cmake commands: # Use `Debug` instead of `Release` for debug builds
cmake . -B build -DCMAKE_BUILD_TYPE=Release
cmake --build build --config Release --parallel |
Resolves #12