Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple drop-ins for pushd and popd to prevent some rpmbuild issues #182

Open
wants to merge 1 commit into
base: wip-testing
Choose a base branch
from

Conversation

unxmaal
Copy link
Collaborator

@unxmaal unxmaal commented Sep 28, 2021

No description provided.



%install
install -m 755 -p -D %{SOURCE0} $RPM_BUILD_ROOT/usr/sgug/bin/pushd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is totally a better macro for this path but I don't know that I care (the sgug bit)

@Jenna64bit
Copy link
Collaborator

Jenna64bit commented Oct 6, 2021

Not working with the original lcms SPEC file. Note - the patch error comes from the directory not changing in the first call to pushd.

+ /usr/sgug/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ pushd samples
samples /usr/people/jenna/rpmbuild/BUILD/lcms-1.19' '
+ echo 'Patch #0 (lcms-1.19-rhbz675186.patch):'
+ echo 'Patch #0 (lcms-1.19-rhbz675186.patch):'
Patch #0 (lcms-1.19-rhbz675186.patch):
+ </usr/people/jenna/rpmbuild/SOURCES/lcms-1.19-rhbz675186.patch
+ /usr/sgug/bin/patch --no-backup-if-mismatch -p0 '--fuzz=0'
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- icclink.1  2011-01-11 11:59:54.000000000 +0000
|+++ icclink.1  2011-02-04 15:03:14.000000000 +0000
--------------------------
File to patch: samples/icclink.1
patching file samples/icclink.1
+ popd
/usr/sgug/bin/popd: line 4: dirname: missing directory name.
error: Bad exit status from /usr/sgug/var/tmp/rpm-tmp.035118 (%prep)

@mach-kernel mach-kernel added the enhancement New feature or request label Nov 22, 2021
@@ -0,0 +1,4 @@
#!/usr/sgug/bin/bash
DIR_STACK=${DIR_STACK#* }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re @Jenna64bit's error -- maybe invoke cd .. -- it will be at least reliable. Can one of you try this? I just ran into the same issue on my end with another package and this seems like it's 3/4 across the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants