Readjusting Halstead Metrics #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for helping to uncover and fix this @Maimunar! I will shortly release v2.0.0 since this changes output scores |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the library (with the json tag) I noticed a discrepancy between some of the logic presented in the json and the logic shown in the research I read (resources below), namely:
This PR goes over the changes and also fixes the tests
Some resources I used to get the right definitions:
https://en.wikipedia.org/wiki/Halstead_complexity_measures
https://www.geeksforgeeks.org/software-engineering-halsteads-software-metrics/
If there is any other contribution guideline I missed, I'm happy to assist with that