Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

51: Add config path CLI argument #55

Merged
merged 5 commits into from
Oct 21, 2023
Merged

51: Add config path CLI argument #55

merged 5 commits into from
Oct 21, 2023

Conversation

marcusedwardhaslam
Copy link
Collaborator

@marcusedwardhaslam marcusedwardhaslam commented Oct 20, 2023 •
edited
Loading

Adds optional config path CLI argument...

@marcusedwardhaslam marcusedwardhaslam self-assigned this Oct 20, 2023
@marcusedwardhaslam marcusedwardhaslam linked an issue Oct 20, 2023 that may be closed by this pull request
Add the ability to specify the path to the config file #51
Closed
@sgb-io
Copy link
Owner

sgb-io commented Oct 20, 2023

Agreed that it should panic if config path is specified but later not found

@sgb-io sgb-io mentioned this pull request Oct 20, 2023
Closed
@marcusedwardhaslam marcusedwardhaslam force-pushed the 51-add-the-ability-to-specify-the-path-to-the-config-file branch from 7b33010 to bba63ba Compare October 20, 2023 22:38
@marcusedwardhaslam marcusedwardhaslam marked this pull request as ready for review October 20, 2023 22:46
@marcusedwardhaslam marcusedwardhaslam force-pushed the 51-add-the-ability-to-specify-the-path-to-the-config-file branch from aba9b9f to 58462e2 Compare October 20, 2023 22:50
@marcusedwardhaslam marcusedwardhaslam marked this pull request as draft October 20, 2023 23:00
@marcusedwardhaslam marcusedwardhaslam marked this pull request as ready for review October 20, 2023 23:50
@marcusedwardhaslam
51: Use proper error handling in config module
7f181af 
- Bubble error structures from results up to lib.rs
- Surface app errors to user via stderr in main
- Top level FTAError
- Module level ConfigError
@marcusedwardhaslam marcusedwardhaslam force-pushed the 51-add-the-ability-to-specify-the-path-to-the-config-file branch from b4e659a to 7f181af Compare October 21, 2023 09:33
@sgb-io sgb-io merged commit b31bc8a into main Oct 21, 2023
8 checks passed
@sgb-io sgb-io deleted the 51-add-the-ability-to-specify-the-path-to-the-config-file branch October 21, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgb-io sgb-io Awaiting requested review from sgb-io

Assignees

@marcusedwardhaslam marcusedwardhaslam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to specify the path to the config file
2 participants
@marcusedwardhaslam @sgb-io