Add an option to include comments in FTA score calculation #47

bencollins54 · 2023-10-18T22:20:53Z

Add an option to include comments in FTA score calculation.
Exclude comments by default.

Add code for counting comments. Update deps.

crates/fta/src/parse/mod.rs

crates/fta/src/lib.rs

crates/fta/src/config/mod.rs

crates/fta/src/lib.rs

crates/fta/src/parse/mod.rs

sgb-io · 2023-10-20T21:01:30Z

e2e test case in test.yml needs the line count updating

sgb-io · 2023-10-20T21:20:45Z

Fta score in the e2e test also needs to be updated, since the number of lines was corrected

Add tests to verify metrics aren't changed by comments.

d468cb9

Add code for counting comments. Update deps.

bencollins54 linked an issue Oct 18, 2023 that may be closed by this pull request

Consider adding an option to ignore comments #45

Closed

bencollins54 added 4 commits October 18, 2023 23:32

Add include_comments option.

0561f44

Improve comment line counting.

0e8cb31

Strip new lines.

d8b39d2

Fix tests.

f8fa1bd

sgb-io mentioned this pull request Oct 19, 2023

Consider adding an option to ignore comments #45

Closed

Fixes & perf improvement.

cf25f32

sgb-io reviewed Oct 20, 2023

View reviewed changes

crates/fta/src/parse/mod.rs Outdated Show resolved Hide resolved

crates/fta/src/lib.rs Show resolved Hide resolved

sgb-io reviewed Oct 20, 2023

View reviewed changes

bencollins54 added 5 commits October 20, 2023 20:37

Fix formatting.

905842c

Clean up traits methods.

2eef2f6

Add test for include_comments.

7151016

Fix inverted conditional

86d2da9

Correct test and document why the line count is correct.

17b663e

Fix CI test.

3f295ee

Fix tests.

198cca4

bencollins54 marked this pull request as ready for review October 20, 2023 21:29

Fix e2e tests.

6bdb052

sgb-io merged commit f70680a into main Oct 20, 2023
8 checks passed

sgb-io deleted the 45-consider-adding-an-option-to-ignore-comments branch October 20, 2023 22:04

Provide feedback