Allow getting output shared libraries #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Native image can output shared libraries along with the native native binary. These are placed in the output directory next to the binary executable, but I could not find a way of collecting these files.
I wanted to be able to detect the files that native image would output and declare those as outputs but I wasn't able to figure out that. It seems that the libraries that are produced are determined by the code written and so we cannot determine this just by inspecting the command we are invoking.
Instead I exposed an attr so the user can specify the extra files they expect to be generated. This is probably not ideal but it works for my use case.
Any feedback is appreciated.