Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a serialization_configuration option for native_image #466

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

chrismgrayftsinc
Copy link
Contributor

Fixes #465

@sgammon sgammon self-assigned this Sep 19, 2024
@sgammon sgammon added the feature Mainline feature work label Sep 19, 2024
@sgammon sgammon added this to the 1.0.0 milestone Sep 19, 2024
Copy link
Owner

@sgammon sgammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrismgrayftsinc Looks clean, thank you very much for contributing 😄

I have authorized CI to run. To fix the DCO and Commitlint checks:

git commit --amend --sign

And edit your commit to follow the convention:

feat: add `serialization_configuration` option for `native_image`

You can use whatever commit message you want. As long as it has the feat prefix, it'll pass the check.

@sgammon sgammon added the native-image Features and issues relating to the Native Image tool label Sep 19, 2024
Copy link

@sgammon
Copy link
Owner

sgammon commented Sep 29, 2024

Thanks @chrismgrayftsinc for this contribution and for that edit; I hate to ask and might even remove the requirement. This will make it into the next release and of course you'll be credited. Cheers!

@sgammon sgammon merged commit 8d49aab into sgammon:main Sep 29, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Mainline feature work native-image Features and issues relating to the Native Image tool
Projects
Development

Successfully merging this pull request may close these issues.

Support serialization configuration
2 participants