Skip to content

Commit

Permalink
fix: remove incompatible_remote_results_ignore_disk
Browse files Browse the repository at this point in the history
Fixes and closes #409

Signed-off-by: Sam Gammon <[email protected]>
  • Loading branch information
sgammon committed Sep 29, 2024
1 parent 43aa71a commit 7f2e557
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
6 changes: 0 additions & 6 deletions .aspect/bazelrc/performance.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ build --noexperimental_check_output_files
fetch --noexperimental_check_output_files
query --noexperimental_check_output_files

# Don't apply `--noremote_upload_local_results` and `--noremote_accept_cached` to the disk cache.
# If you have both `--noremote_upload_local_results` and `--disk_cache`, then this fixes a bug where
# Bazel doesn't write to the local disk cache as it treats as a remote cache.
# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_remote_results_ignore_disk
build --incompatible_remote_results_ignore_disk

# Directories used by sandboxed non-worker execution may be reused to avoid unnecessary setup costs.
# Save time on Sandbox creation and deletion when many of the same kind of action run during the
# build.
Expand Down
1 change: 0 additions & 1 deletion tools/bazel/cache.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ build:buildless --remote_cache=https://global.less.build

build --modify_execution_info=PackageTar=+no-remote
build --remote_local_fallback
build --incompatible_remote_results_ignore_disk
build --noexperimental_check_output_files
build --nolegacy_important_outputs
build --incompatible_default_to_explicit_init_py
Expand Down
1 change: 0 additions & 1 deletion tools/bazel/strict.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ build:strict --incompatible_no_attr_license
build:strict --incompatible_py2_outputs_are_suffixed
build:strict --incompatible_py3_is_default
build:strict --incompatible_remote_output_paths_relative_to_input_root
build:strict --incompatible_remote_results_ignore_disk
build:strict --incompatible_remote_symlinks
build:strict --incompatible_remove_legacy_whole_archive
build:strict --incompatible_require_ctx_in_configure_features
Expand Down

0 comments on commit 7f2e557

Please sign in to comment.