Initial changes required to change our code to use the new database framework and some cleanup. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmar3a
force-pushed
the
new-database-framework
branch
2 times, most recently
from
09b88c1
to
7a148ad
Compare
- Replaced the mixture of tabs and spaces with spaces.
- Made the white-space for the file consistent.
Note: In general it's probably not a good idea to make white-space
changes without making actual changes to the code as it makes
the Git history more messy; however, there aren't too many
commits for this file yet and most of the commits are just
changes to the logging mechanism used by the program.
- Removed the helper methods as they didn't seem necessary. Grouping the lines that belong together with comments is clear enough.
rmar3a
force-pushed
the
new-database-framework
branch
from
7a148ad
to
6754cc2
Compare
rmar3a
changed the title
- Several settings in the configuration file don't appear to be retrieved by our code (not used), so I am removing them from the configuration file to increase readability.
rmar3a
force-pushed
the
new-database-framework
branch
from
6754cc2
to
0b34b77
Compare
|
Okay, I think this should be good enough for now. We can go over the changes in today's meeting and hopefully merge it in 🙂 |
|
Note: I think the changes in this pull request are a step towards addressing this issue on GitHub: #32 |
rmar3a
force-pushed
the
new-database-framework
branch
from
b6401a1
to
a752216
Compare
…o it. - Initial code for the new database framework that is an attempt to abstract the database logic from the Bayesian Network learning logic. - Created a new FactorBaseDataBase interface so that other databases can be supported in the future more easily. - Created a custom DataBaseException that can be thrown by any database technology that implements the FactorBaseDataBase interface. - All the logic found in MakeSetup.java was moved into MySQLFactorBaseDataBase.java since the logic makes more sense to be in this file, i.e. it manipulates the given MySQL database, and MakeSetup.java was moved into a new subdirectory (called "refactored") of the obsolete directory. - Updated RunBB.java to use the new database framework for the database setup logic portion of the process.
rmar3a
force-pushed
the
new-database-framework
branch
from
a752216
to
06d1626
Compare
oschulte
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a temporary pull request to show the current direction I am headed in.
Do not merge this pull request yet as it is an incomplete version.