Use configuration file to set database collation. #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at how we pass around the values in the configuration file, there's probably a cleaner way to do it if we need to add/remove the list of options in the configuration file. However, this is probably good enough for now.
In addition, it looks like the collation might have been causing the non-deterministic results we were seeing in the build. Making sure the collation is consistent for all the databases (input and output) seems to make the output in the build consistent now. Guess we will have a better idea after more builds.
Update: Looks like the non-deterministic issue is still there and seems to have a different set of possible outcomes (each collation seems to have its own distinct set of possible non-deterministic outcomes) 😢
The issue is with the order of the numbers for this "table" in the BIF file that gets generated:
Not sure if the order matters, will need to look into what the values in this table are exactly (some sort of conditional probabilities?).