refactor: abstract structs event.Raw and event.Slo into interfaces and add UID to each event #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lksv
reviewed
Aug 26, 2021
rudo-thomas
reviewed
Aug 26, 2021
Signed-off-by: Martin Chodur <[email protected]>
Signed-off-by: Martin Chodur <[email protected]>
Signed-off-by: Martin Chodur <[email protected]>
Signed-off-by: Martin Chodur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intended to just add the UID to each event.
The unfortunate thing is that we used the event structs
RawandSlodirectly with exported fields, so we had no way of ensuring each event has the UID. We would need a constructor of some kind.It would be all way simpler if we would use the interfaces from the beginning. Unfortunately, it was not the case.
TBH, the separate events
RawandSloare almost identical. I'm thinking if we need to have both of them at all.In that case, the change would be quite easy after switching to the interfaces now.
So... eventually I took the stab and refactored the event structs into interfaces and switched to having constructors which ensures consistency in the events and that they have the UID set.
And once again, It's huge, and I don't know how to split this, sorry :/
Tests are passing, e2e tests are passing, and I tested it locally. Hopefully it does not break anything 🤞