Allow any supported music type to play #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezero
reviewed
Sep 30, 2024
sezero
reviewed
Sep 30, 2024
|
@ericwa, @andrei-drexler: what do you think? |
|
@sezero requested modification made |
Personally, I think tracker music is a bit anachronistic for Quake, but it's a feature that's been requested previously for IW, and since the libraries already support these formats and the engine changes are minimal, I guess it makes sense to add this and make some modders happy. |
sezero
pushed a commit
that referenced
this pull request
Sep 30, 2024
|
OK, patch is in. Thanks. |
vsonnier
pushed a commit
to Novum/vkQuake
that referenced
this pull request
Oct 1, 2024
alexey-lysiuk
pushed a commit
to alexey-lysiuk/quakespasm-exp
that referenced
this pull request
Oct 1, 2024
sezero/quakespasm#113 (cherry picked from commit d8d2b54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the restriction on CDRIP_TYPES for music. This unnecessary restriction makes the tracker formats supported by the engine (umx, mod, it, etc.) useless as they cannot be used for map music.
Removed the defines as well, as they were not used anywhere else.