This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
Return the correct exit code #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r. Used directly with Kernel#exit, this will result in unexpected behaviour. Providing a value of 256 will result in exit code 0 which is not appropriate. Co-authored-by: Sven Winkler <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$CHILD_STATUS.to_idoes not just return the exit code. As described in the ruby docs it returns a 16-bit integer with the process informations and exit code. This will result in a value greater than 255, which is an invalid exit code. Passing a value greater than 255 toexitresults in an exit code of0.$CHILD_STATUS.exitstatusreturns just the exit code.This is similar to #40. I had this problem where on parallel rspec worker crashed but the exit code returned by
zeus-parallel_testswas still0.I have also fixed the gem versions to work with all tested ruby versions.