-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress bar #75
base: master
Are you sure you want to change the base?
Add progress bar #75
Conversation
@@ -8,6 +8,7 @@ build = "build.py" | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.9" | |||
progress = "^1.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't want any third-party dependencies. Since progress
is a quite lightweight project, can you just migrate to chaine
? As a submodule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer the Bar
one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer the Bar
one, the integration of progress
is currently temporary and for testing purposes. The main reason for this very drafty PR is, that I'm continue to work on this PR on another computer.
I'm currently not sure if I will integrate this directly into the C code or as an outer layer within the Python code, but I would prefer the first one to have more control over the bar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #68.
Draft PR.