Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Add ParamId to output_ui & value_widget{,_connected} methods #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tinou98
Copy link

@tinou98 tinou98 commented May 26, 2023

Currently, only the name is provided. I added to InputId or OutputId.
It's problematic on my side as I handle multiple many-to-many relation with multiple inputs with the same name.

Warning : This is a breaking change, all client code must add this parameter to these 3 methods. This would be possible to avoid that at the cost of complexity.

@kamirr
Copy link
Contributor

kamirr commented May 26, 2023

I feel like the signatures of those methods are getting bloated, maybe we could make param_name be a member of {Input,Output}Param which is easily accessible in O(1) and drop it from the Vec? Also, considering that we introduce a breakage into the signatures of these functions we could also re-order the fields to make stuff a bit more consistent.

Other than that I like this change, param ids are certainly more fundamental than names and I've personally found myself recovering the id from the name a couple of times.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants