Feature: Timeout Parameter #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the action CLI option to BaseCommand. Parse input as integer with default of 30 (which seems to be what all the SQL classes default to for their timeout).
Pass Console's `TimeoutSec` to Model's `TimeoutSec`.
Pass Command's `TimeoutSec` into Model.Database object as well as the
SqlConnectionStringBuilder.
- Giving the timeout to only the Connection string isn't enough to
allow for variable timeouts. Some SQL classes ignore that timeout,
apparenly.
Pass timeout down again into `Table.ImportData()` so that the import can set a timeout on its `SqlBulkCopy` object. - This is what actually allows for extended timeouts on `schemazen create [...]` commands.
Add timeout param for `Table.ImportData` unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does 2 things:
--timeoutparameter to BaseCommand.schemazen create.This is not a complete timeout for everything, but it is a solution for #62 import timeout issues, which I also had and needed to fix.
#193 implements a timeout for
schemazen script, which this does not do. Thank you to @rhumborl for giving me enough code in the diffs to make figuring out this patch much quicker.