chore: add lints and enforce stricter typing and future handling

serverpod · Jan 2, 2025 · 6f53f4f · 6f53f4f
1 parent 0a1b4a2
commit 6f53f4f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -1 +1,6 @@
 include: package:lints/recommended.yaml
+
+linter:
+  rules:
+      - avoid_dynamic_calls
+      - unawaited_futures
diff --git a/lib/src/headers/headers.dart b/lib/src/headers/headers.dart
@@ -1389,7 +1389,7 @@ final class _HeadersImpl extends Headers {
     return map;
   }
 
-  /// Date-related headers
+  /// Date related headers
   Map<String, DateTime?> get _dateHeadersMap => {
         Headers.dateHeader: date ?? DateTime.now().toUtc(),
         Headers.expiresHeader: expires,
@@ -1413,7 +1413,7 @@ final class _HeadersImpl extends Headers {
             accessControlRequestMethod?.value,
       };
 
-  /// List<String>-related headers
+  /// String list related headers
   Map<String, List<String>?> get _listStringHeadersMap =>
       <String, List<String>?>{
         Headers.viaHeader: via,
@@ -1422,7 +1422,7 @@ final class _HeadersImpl extends Headers {
         Headers.trailerHeader: trailer,
       };
 
-  /// Uri-related headers
+  /// Uri related headers
   Map<String, Uri?> get _uriHeadersMap => <String, Uri?>{
         Headers.locationHeader: location,
         Headers.refererHeader: referer,
@@ -1431,7 +1431,7 @@ final class _HeadersImpl extends Headers {
         Headers.hostHeader: host,
       };
 
-  /// TypedHeader-related headers
+  /// TypedHeader related headers
   Map<String, TypedHeader?> get _typedHeadersMap => <String, TypedHeader?>{
         Headers.fromHeader: from,
         Headers.acceptEncodingHeader: acceptEncoding,

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -17,7 +17,7 @@ dependencies:
   convert: ^3.1.1
 
 dev_dependencies:
-  dart_flutter_team_lints: ^3.0.0
+  lints: '>=3.0.0 <5.0.0'
   http: '>=1.0.0 <2.0.0'
   test: ^1.24.2
   test_descriptor: ^2.0.1
diff --git a/test/relic_server_serve_test.dart b/test/relic_server_serve_test.dart
@@ -126,7 +126,7 @@ void main() {
       Uri.http('localhost:$_serverPort', '/'),
     );
     request.sink.add([1, 2, 3, 4]);
-    request.sink.close();
+    await request.sink.close();
 
     var response = await request.send();
     expect(response.statusCode, HttpStatus.ok);