Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string conversion was missing #37

Closed
wants to merge 1 commit into from

Conversation

Preeti2095
Copy link

The code snippet for Google Shopping contain the missing code for int to string type conversion in print statement.

@dimitryzub
Copy link
Contributor

@Preeti2095 Thank you for this PR 👍

For now, we will not be merging this because there's a #36 that focuses on updating docs completely. If you want, you can write your suggestions there.

Once again, thank you for taking the time to create this PR 🙂

@Preeti2095
Copy link
Author

Oh i see...so shall i close this pull request?

@dimitryzub
Copy link
Contributor

dimitryzub commented Nov 4, 2022

@Preeti2095 Yes, it would logical as there's #36 to solve similar things you've suggested in this PR 🙂

Once again, feel free to write suggestions in the #36 👍

@Preeti2095 Preeti2095 closed this Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants