Code

Clean the Monero lib for auditing#577

Code

Merged

kayabaNerve merged 67 commits intodevelopserai-dex/serai:developfrom monero-tidyserai-dex/serai:monero-tidyCopy head branch name to clipboardJul 7, 2024

+11,020-8,236

Commits

Commits on Jul 4, 2024

• Remove unsafe creation of dalek_ff_group::EdwardsPoint in BP+

  kayabaNerve

  committed
  98b08ea

• Rename Bulletproofs to Bulletproof, since they are a single Bulletproof

  Show description for f5d9d03
  kayabaNerve

  committed
  f5d9d03

• Make CLSAG signing private

  Show description for cd8b054
  kayabaNerve

  committed
  cd8b054

• Remove the distribution cache

  Show description for f1ad768
  kayabaNerve

  committed
  f1ad768

• Tidy Borromean/MLSAG a tad

  kayabaNerve

  committed
  c165c36

• Remove experimental feature from monero-serai

  kayabaNerve

  committed
  d2a27dc

• Move amount_decryption into EncryptedAmount::decrypt

  kayabaNerve

  committed
  a1d1de0

• Various RingCT doc comments

  kayabaNerve

  committed
  5cdae6e

• Begin crate smashing

  kayabaNerve

  committed
  784a273

• Further documentation, start shoring up API boundaries of existing crates

  kayabaNerve

  committed
  9c21791

• Document and clean clsag

  kayabaNerve

  committed
  865dee8

• Add a dedicated send/recv CLSAG mask struct

  Show description for 798ffc9
  kayabaNerve

  committed
  798ffc9

• Smash out monero-bulletproofs

  Show description for f7c13fd
  kayabaNerve

  committed
  f7c13fd

• Correct no-std builds for monero-clsag and monero-bulletproofs

  kayabaNerve

  committed
  d9107b5

• Tidy and document monero-bulletproofs

  Show description for 77a2496
  kayabaNerve

  committed
  77a2496

• Error if missing documentation

  kayabaNerve

  committed
  60d5c06

• Smash out MLSAG

  kayabaNerve

  committed
  303e72c

• Smash out Borromean

  kayabaNerve

  committed
  3e82ee6

• Tidy up monero-serai as a meta crate

  kayabaNerve

  committed
  3a1c6c7

• Smash out RPC, wallet

  kayabaNerve

  committed
  d740bd2

• Document the RPC

  kayabaNerve

  committed
  08b95ab

• Improve docs a bit

  kayabaNerve

  committed
  6f61861

• Move Protocol to monero-wallet

  kayabaNerve

  committed
  b5b9d4a

• Incomplete work on using Option to remove panic cases

  kayabaNerve

  committed
  1db4091

• Finish documenting monero-serai

  kayabaNerve

  committed
  74aaac4

• Remove TODO on reading pseudo_outs for AggregateMlsagBorromean

  kayabaNerve

  committed
  6fc8b30

• Only read transactions with one Input::Gen or all Input::ToKey

  Show description for df095f0
  kayabaNerve

  committed
  df095f0

• Smash out polyseed

  kayabaNerve

  committed
  1e2e3bd

• Smash out seed

  kayabaNerve

  committed
  11dba91

• Get the repo to compile again

  kayabaNerve

  committed
  0b20004

• Smash out Monero addresses

  kayabaNerve

  committed
  eb0c19b

• Document cargo features

  Show description for 0f47753
  kayabaNerve

  committed
  0f47753

• Fix deserializing v2 miner transactions

  kayabaNerve

  committed
  b3b0edb

• Rewrite monero-wallet's send code

  Show description for 70c36ed
  kayabaNerve

  committed
  70c36ed

• Add SignableTransaction Read/Write

  kayabaNerve

  committed
  abd48e9

• Restore Monero multisig TX code

  kayabaNerve

  committed
  08d604f

• Correct invalid RPC type def in monero-rpc

  kayabaNerve

  committed
  891362a

• Update monero-wallet tests to compile

  Show description for 8319d21
  kayabaNerve

  committed
  8319d21

• Clean and document monero-address

  kayabaNerve

  committed
  69e077b

• Sync rest of repo with monero-serai changes

  kayabaNerve

  committed
  0624661

• Represent height/block number as a u32

  kayabaNerve

  committed
  64e74c5

• Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scanner/GuaranteedScanner

  Show description for daa0f8f
  kayabaNerve

  committed
  daa0f8f

• Remove non-small-order view key bound

  Show description for b56c6fb
  kayabaNerve

  committed
  b56c6fb

• Finish documenting monero-serai

  kayabaNerve

  committed
  08169e2

• Correct imports for no-std

  kayabaNerve

  committed
  3de89c7

• Remove possible panic in monero-serai on systems < 32 bits

  Show description for 0f9a5af
  kayabaNerve

  committed
  0f9a5af

• Restore the reserialize chain binary

  kayabaNerve

  committed
  e94a04d

Commits on Jul 5, 2024

• fmt, machete, GH CI

  kayabaNerve

  committed
  90880cc

Commits on Jul 6, 2024

• Correct misc TODOs in monero-serai

  kayabaNerve

  committed
  1f5e5fc

• Have Monero test runner evaluate an Eventuality for all signed TXs

  kayabaNerve

  committed
  04df229

• Fix a pair of bugs in the decoy tests

  Show description for 788c4fc
  kayabaNerve

  committed
  788c4fc

• Fix remaining bugs in monero-wallet tests

  kayabaNerve

  committed
  b2c962c

• Reject torsioned spend keys to ensure we can spend the outputs we scan

  kayabaNerve

  committed
  d847ec5

• Tidy inlined epee code in the RPC

  kayabaNerve

  committed
  0631607

• Correct the accidental swap of stagenet/testnet address bytes

  kayabaNerve

  committed
  2334725

• Remove unused dep from processor

  kayabaNerve

  committed
  6357bc0

• Handle Monero fee logic properly in the processor

  kayabaNerve

  committed
  9f7dbf2

• Document v2 TX/RCT output relation assumed when scanning

  kayabaNerve

  committed
  c138950

Commits on Jul 7, 2024

• Adjust how we mine the initial blocks due to some CI test failures

  kayabaNerve

  committed
  3cf0b84

• Fix weight estimation for RctType::ClsagBulletproof TXs

  kayabaNerve

  committed
  4743ea7

• Again increase the amount of blocks we mine prior to running tests

  kayabaNerve

  committed
  d99ed96

• Correct the if check about when to mine blocks on start

  Show description for 86facae
  kayabaNerve

  committed
  86facae

• Run Monero on Debian, even for internal testnets

  Show description for c521bbb
  kayabaNerve

  committed
  c521bbb

• Don't attempt running tests on the verify-chain binary

  Show description for 1bfd7d9
  kayabaNerve

  committed
  1bfd7d9

• Increase minimum Monero fee in processor

  Show description for 9e4d83b
  kayabaNerve

  committed
  9e4d83b

• Distinguish fee from necessary_fee in monero-wallet

  Show description for d88bd70
  kayabaNerve

  committed
  d88bd70

• Restore minimum Monero fee from develop

  kayabaNerve

  committed
  6994d93