Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

March 2024 - Rust Nightly Update #536

Closed
wants to merge 1 commit into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 1, 2024

PR auto-generated by a GitHub workflow.

@github-actions github-actions bot added the improvement This could be better label Mar 1, 2024
@kayabaNerve
Copy link
Member

This would required a patch file which is a few hundred lines due to our explicit importing of vec::Vec in potentially no-std crates.

rust-lang/rust#121708 (comment)

This is quite unfortunate. Some of the other lints (msrv checks, which we apparently fail) would be quite useful.

@kayabaNerve kayabaNerve closed this Mar 2, 2024
@kayabaNerve kayabaNerve deleted the nightly-2024-03 branch March 2, 2024 20:45
@kadiwa4
Copy link

kadiwa4 commented Mar 3, 2024

Usually, you simply have to replace

#![cfg_attr(not(feature = "std"), no_std)]

with

#![no_std]

#[cfg(feature = "std")]
extern crate std;

to avoid including the std prelude.

@kayabaNerve
Copy link
Member

... hm. That may make this manageable?

Thanks for the heads up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants