Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validator set rotation test for the node side #532

Merged
merged 5 commits into from
Feb 24, 2024
Merged

Add validator set rotation test for the node side #532

merged 5 commits into from
Feb 24, 2024

Conversation

akildemir
Copy link
Contributor

No description provided.

kayabaNerve
kayabaNerve reviewed Feb 18, 2024
View reviewed changes
Copy link
Member

@kayabaNerve kayabaNerve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments, except for discussion over the decision to use a feature instead of a config argument on the node-side with a CLI arg.

substrate/client/src/serai/mod.rs Outdated Show resolved Hide resolved
substrate/client/src/serai/mod.rs Outdated Show resolved Hide resolved
substrate/client/src/serai/mod.rs Show resolved Hide resolved
substrate/client/tests/validator_sets.rs Show resolved Hide resolved
substrate/client/tests/validator_sets.rs Outdated Show resolved Hide resolved
substrate/validator-sets/pallet/src/lib.rs Outdated Show resolved Hide resolved
@kayabaNerve kayabaNerve merged commit 627e7e6 into serai-dex:develop Feb 24, 2024
9 of 15 checks passed
kayabaNerve pushed a commit that referenced this pull request Feb 25, 2024
@akildemir @kayabaNerve
Add validator set rotation test for the node side (#532)
c10e6e5 
* add node side unit test

* complete rotation test for all networks

* set up the fast-epoch docker file

* fix pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayabaNerve kayabaNerve kayabaNerve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akildemir @kayabaNerve