monero: make dummy payment ID zeroes when it's included in a tx #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also did some minor cleaning of InternalPayment::Change
kayabaNerve
pushed a commit
that referenced
this pull request
Feb 25, 2024
* monero: make dummy payment ID zeroes when it's included in a tx Also did some minor cleaning of InternalPayment::Change * Lint * Clarify comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures when sending to a single counter-party who doesn't use an integrated address, the counter-party would see a payment ID of all zeroes, rather than random values. Matches wallet2's behavior (can check the change to the
receipt_of_wallet_rpc_tx_standardtest in this PR to see wallet2's behavior).Note the 2 special circumstances in which wallet2 ignores the payment ID:
Also note that when using monero-serai to send to 2 destinations with no change, monero-serai would not include a payment ID since 1) it doesn't know which recipient should see the payment ID, and 2) this tx is fingerprintable by the fee anyway (the change is shunted to the fee).
I also did some minor cleaning of
InternalPayment::Change