Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check miner tx has a miner input when deserializing. #506

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

Boog900
Copy link
Contributor

@Boog900 Boog900 commented Jan 5, 2024

No description provided.

@kayabaNerve
Copy link
Member

This doesn't resolve the panic noted in fn number as it's still possible to manually construct a block without a miner TX. While I'm fine merging this, do you want to fix that in this PR, in a new PR, or shall I follow up there? (any is fine with me)

@kayabaNerve kayabaNerve added improvement This could be better monero An issue with the Monero library/integration labels Jan 5, 2024
@Boog900
Copy link
Contributor Author

Boog900 commented Jan 5, 2024

I didn't want to change the API of the number function and IMO if someone is creating invalid blocks manually panicking is probably ok (should be documented though). I had a look and I think it would probably be best for you to decide how to handle invalid miner txs in number as its used in places where i'm unsure what should be done.

@kayabaNerve kayabaNerve merged commit e7b0ed3 into serai-dex:develop Jan 6, 2024
16 checks passed
@kayabaNerve kayabaNerve deleted the check-miner-tx branch January 6, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This could be better monero An issue with the Monero library/integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants