monero: if seed checksum fails, keep trying more languages #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK code changes. NACK test changes. You explicitly should not remove an existing vector. Please add new vectors for the multiple faulty seeds you observed. Removing those print statements sets us up to repeat a situation with lack of logging. They should not be removed. You noted they panicked and were accordingly ineffective. Please fix them, don't remove them. |
kayabaNerve
added
bug
|
Per monero-project/monero#9089, we need to rip out these code changes and the code it changed for explicitly specifying the language. Please say RIP and appreciate the glorious negative LoC delta. |
|
Closing in favor of #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
The Spanish seed I included in this PR has the same prefixes as words from the English list. This could cause the language matcher to think the seed is in english, and then fail the checksum.
The solution in this PR matches the monero repo's behavior (notice the for loop continues on checksum fail: https://github.com/monero-project/monero/blob/ac02af92867590ca80b2779a7bbeafa99ff94dcb/src/mnemonics/electrum-words.cpp#L154)