Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rustls with boring-ssl #457

Closed
wants to merge 3 commits into from
Closed

Replace rustls with boring-ssl #457

wants to merge 3 commits into from

Conversation

kayabaNerve
Copy link
Member

This removes all re-attempts present in monero-serai's RPC and is an attempt to narrow down the sporadic failures.

Inspired by hyperium/hyper#3427

@kayabaNerve kayabaNerve added the bug Something isn't working label Nov 26, 2023
@kayabaNerve
Copy link
Member Author

Without re-attempts, the CI consistently failed due to the amount of requests we made during a CI run. Recently, a run failed even with re-attempts, making the issue incredibly rare yet still present and reachable.

I'm just curious what this CI reports.

@kayabaNerve
Copy link
Member Author

2023-11-27T05:36:57.9226749Z In CI, so clearing cache to prevent hitting the storage limits.
2023-11-27T05:36:57.9227681Z thread 'tests::mint_and_burn::mint_and_burn_test' panicked at tests/full-stack/src/tests/mint_and_burn.rs:147:78:
2023-11-27T05:36:57.9228672Z called `Result::unwrap()` on an `Err` value: ConnectionError("Hyper(hyper::Error(IncompleteMessage))")

This still got IncompleteMessage, albeit, potentially with a very very reduced rate? I think if the edits I applied to coins/monero were applied to develop, while remaining on rustls, all of these CI runs would've failed.

Since there's no definity here, and this adds multiple depends, I'm fine closing this.

Remaining candidates are our async driving code, hyper itself, and epee (the server).

This removes all re-attempts present in monero-serai's RPC and is an attempt to
narrow down the sporadic failures.

Inspired by hyperium/hyper#3427
I did compile all feature combinations to ensure it's proper now.
@kayabaNerve
Copy link
Member Author

I reopened this when I attempted moving to hyper 1.0, as possible thanks to an open PR to hyper-boring.

hyper 1.0 + boring-ssl still has the incomplete message issue, so this PR should be dropped.

Its work on moving to 1.0 should be yoinked to a new PR once we can move over with rustls.

@kayabaNerve kayabaNerve deleted the boring-ssl branch January 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant